Repository navigation
Fix Assistant profile heartbeat timestamp precision - #225
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Assistant profile heartbeat regression uncovered while verifying main after #222 and #223 merged.
PostgreSQL timestamps retain microseconds; node-postgres converts timestamp results to millisecond Date values. Passing that rounded observation back to SQL can incorrectly classify a heartbeat at the same database instant as being in the future. Keep the database observation as timestamp text for heartbeat and lease comparisons, while using Date for calendar and display work. The 30-second freshness window and future-heartbeat rejection remain intact.
Add a real-database regression that pins a heartbeat and observation to the same transaction instant with nonzero microseconds. It also verifies a future heartbeat remains unavailable. Transaction rollback restores heartbeat fixtures.
Evidence
[true, false], received[false, false].Context
Main CI first encountered an unrelated Chromium
Target.createTargettimeout in an unchanged Gantt test. Its rerun exposed this precision issue. Full remote CI will qualify the corrected main commit; this PR does not weaken or skip either test.