Skip to content

refactor(core): source control in folders - #388

Merged
kinqsradio merged 27 commits into
mainfrom
refactor/core-source-control
Nov 9, 2026
Merged

kinqsradio merged 27 commits into
mainfrom
refactor/core-source-control

Conversation

@kinqsradio

Copy link
Copy Markdown
Member

Summary

  • source_control/forge.rs (2,987 lines) becomes forge/: mod.rs (Forge, front door, 130 lines) with process, parse, github, gitlab, details, pulls, review, merge, create, status, cache and tests.rs.
  • source_control/scm.rs (1,375) becomes scm/: mod.rs (316) with pulls, review, stack, watch, forges; scm_writing.rs (1,155) becomes scm/writing/ (mod.rs, candidate, style).
  • No behaviour change: same orbyn_core::source_control::... paths through re-exports, same git, gh and glab arguments, parsing and strings. git.rs stays whole.
  • Neutral proof: 836 tests before and after, same names; 354 to 359 fn/struct/enum/const/impl names, the only additions are the 5 new impl Core blocks.
  • Rust size baseline: forge.rs entry removed, none added. docs/refactor.md, the source control README and three docs/parity.md file references updated.

Not pure cuts:

  • forge_cache to forge::cache and scm_writing to scm::writing (the two pub(crate) modules): rename commits that also edit the mod line and two paths (app.rs, settings/preferences.rs).
  • Test moves dedent the test body by one level, and tests get their own use lines.
  • scm/writing/style.rs import line repointed to candidate; fields of moved structs widened to pub(super).
  • Cut commits only add use, mod, pub use and pub(super); rustfmt re-wraps some signatures.

Commits that are pure renames: forge.rs to forge/mod.rs, scm.rs to scm/mod.rs. The rest of the list in .git-blame-ignore-revs (cache, writing, tests) are not pure renames, see above.

Parity rows

none

Frames built

Frames built: none

Testing

  • CI covers the rest.
  • Locally: cargo fmt --all --check, cargo clippy --workspace --all-targets -- -D warnings, cargo test --workspace, scripts/check_rust_arch.py.
  • Not tested: packaged app.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Claude Code 2.1.318
  • Models: claude-sonnet-5-5 (all edits)
  • Effort: medium
  • Human role: assigned the task and the target layout; reviews the PR
  • Sources: none

Checklist

  • Works on Windows and macOS
  • web/src/generated with any contract change; docs/architecture.md with any rule change
  • No copied source, secrets, credentials or personal data; no AI attribution in commits, title or branch

@github-actions github-actions Bot added area: core crates/orbyn-core: runs, drivers, workspace, approvals, storage area: ci CI, release and repository settings area: docs docs and Markdown files labels Nov 9, 2026
@kinqsradio
kinqsradio merged commit 196c472 into main Nov 9, 2026
28 checks passed
@kinqsradio
kinqsradio deleted the refactor/core-source-control branch November 9, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI, release and repository settings area: core crates/orbyn-core: runs, drivers, workspace, approvals, storage area: docs docs and Markdown files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant