Repository navigation
refactor(core): source control in folders - #388
Merged
Merged
Conversation
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_control/forge.rs(2,987 lines) becomesforge/:mod.rs(Forge, front door, 130 lines) withprocess,parse,github,gitlab,details,pulls,review,merge,create,status,cacheandtests.rs.source_control/scm.rs(1,375) becomesscm/:mod.rs(316) withpulls,review,stack,watch,forges;scm_writing.rs(1,155) becomesscm/writing/(mod.rs,candidate,style).orbyn_core::source_control::...paths through re-exports, same git, gh and glab arguments, parsing and strings.git.rsstays whole.impl Coreblocks.forge.rsentry removed, none added.docs/refactor.md, the source control README and threedocs/parity.mdfile references updated.Not pure cuts:
forge_cachetoforge::cacheandscm_writingtoscm::writing(the twopub(crate)modules): rename commits that also edit themodline and two paths (app.rs,settings/preferences.rs).uselines.scm/writing/style.rsimport line repointed tocandidate; fields of moved structs widened topub(super).use,mod,pub useandpub(super); rustfmt re-wraps some signatures.Commits that are pure renames:
forge.rstoforge/mod.rs,scm.rstoscm/mod.rs. The rest of the list in.git-blame-ignore-revs(cache, writing, tests) are not pure renames, see above.Parity rows
none
Frames built
Frames built: none
Testing
cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test --workspace,scripts/check_rust_arch.py.Co-authors
none
AI usage
Checklist
web/src/generatedwith any contract change;docs/architecture.mdwith any rule change