Repository navigation
refactor(core): engine drivers in folders - #384
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude.rs,codex.rs,acp.rsbecome folders underagents/driver/; no behaviour change.args,settings,mcp,catalog,protocol,events,planbesideusage,workflows; codex:protocol,sandbox,turn,events,catalog,tools,limits,short_sessions; acp:sessions(wasacp_sessions),events,models,permissions,replay,sign_in.tests.rs. Largest non-test file is now 642 lines (was 3,438).agents::driver::claude::run_args,codex::console_args,acp::known_sign_in, ...) kept through re-exports. Three files leave the Rust size baseline.git mvcommit, a tests commit, then one verbatim cut per new file. Six move commits are in.git-blame-ignore-revs, but they are not all pure renames: two (claude, codexgit mv) also change oneinclude_str!path; the acpgit mvalso rewritessuper::acp_sessions::tosessions::and theuse super::lines insessions.rs; the three tests commits are extraction plus a one-level dedent. Usegit blame -C -C -Cacross the cuts.Not pure cuts (all in the commits named above):
include_str!fixture paths gain../(claude, codex); acpsuper::acp_sessions::becomessessions::and sessions.rsuse super::{..}becomescrate::agents::driver::{..}.use super::*alone.use,mod,pub uselines andpub(super)on items and fields the sibling files need. Code paths changed:sessions::Xtosuper::sessions::Xandsuper::rpc::Xtocrate::agents::driver::rpc::Xin acpreplay.rs;usage.rsandworkflows.rsimportprobe_failed/text_offrom their new homes.claude::parse_mcp_list(pub(crate), no outside user) is no longer re-exported;acpUpdateMapperis visible toacponly (wasdriver), its only other user isacp::sessions.Parity rows
none
Frames built
Frames built: none
Testing
cargo test -- --list(a static count of#[test]attributes is 842; the difference is platform-gated tests, unchanged by this PR) (onlyacp_sessions::testsbecameacp::sessions::tests).cargo fmt --check,cargo clippy --workspace --all-targets -- -D warnings,cargo test -p orbyn-core(833 passed, 3 ignored),cargo test --workspace,scripts/check_rust_arch.pyrun locally.Co-authors
none
AI usage
Checklist
web/src/generatedwith any contract change;docs/architecture.mdwith any rule change (no contract change; architecture.md names the driver folders)