Repository navigation
refactor(web): workspace feature folders and sidebar split - #383
Merged
Merged
Conversation
…arch and delete pieces from Sidebar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
features/workspace/becomessidebar/,palette/andapp-chrome/; the front doorindex.tsexports the same names.Sidebar.tsx1,199 to 590 lines and leaves the long-files baseline (11 to 10 long TypeScript files, 21 direction entries unchanged).addProject.cssstays put.Commits: pure
git mv(8678212, in blame-ignore), import fixes, two cut commits, baseline shrink, docs.Edits that are not pure moves:
vi.mockpaths in moved files,app/,thread/,onboarding/; three renamed baseline keys.useSidebarCatalog(settings and catalog state moved with their effects into one hook at the same call position),useSelectionDismiss(adds the stablesetSelectionto deps),finishDropandmentionInComposertake their refs, store actions andselectedThreadas arguments,handleTreeKeyandfolderMenuItemstake what they read as arguments,SearchFieldandDeleteThreadsDialogare module-level components with no wrapper element.docs/refactor.mdstatus and moved paths indocs/design-inventory.md.Parity rows
none
Frames built
Frames built: none
Testing
npm run check,npm test(1,714 passed),npm run build; mock Playwrightworkspace,pane-resize,titlebar-line,search-fields,selectionspecs (59 passed).Co-authors
none
AI usage
Checklist
web/src/generatedwith any contract change;docs/architecture.mdwith any rule change (none needed)