Repository navigation
refactor(web): thread composer and tool trail folders - #382
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
features/thread/composer/: Composer, chips, extras, traits, model picker, effort glyph, input/markup/code-block helpers and their tests move in;Composer.tsxgoes from 1,109 to 597 lines.features/thread/trail/:ToolTrail.tsxgoes from 876 to 261 lines;PlanRow.tsxandblocks/(one file per renderer or small group) split out.features/thread/index.tsexports the same names (paths only).Composer.tsxandToolTrail.tsxleave the long-files list (13 to 11 long TS files); direction entries stay 21 (paths renamed).Pure moves: commit 1d1268b only (listed in
.git-blame-ignore-revs). Not pure moves:vi.mockpaths, baseline path rename).MentionMenu,composerConstants,suggestions,composerKeys,composerPaste,useAttachments,useStash,useStopRun,useThreadSettings. JSX pieces became components or a function with props:CodeBar,AttachmentStrip,ComposerContext,ComposerField,ComposerBar,controlsMenu. Hook calls moved out ofComposerkeep their effect order; plain state and selector hooks sit in other places than before.useOwnCommandstays inComposer.tsxso no newapp/shortcutsbaseline entry appears.BlockContext;Blockkeeps its hooks.PlanRownow imported fromtrail/PlanRow.docs/refactor.mdstatus, file paths indocs/design-inventory.mdanddocs/parity.md(line numbers there are unchanged and now approximate).Parity rows
none
Frames built
Frames built: none
Testing
npm run check,npm test(1714),npm run build, mock Playwrighttool-calls,workspace,pane-resize,reading-layout(44 passed).layouts.test.tsxfailed once in a full parallel run and passed alone and on rerun.Co-authors
none
AI usage
Checklist
web/src/generatedwith any contract change;docs/architecture.mdwith any rule change