Skip to content

fix(web): keep Ledger content clear of its details rail - #366

Merged
kinqsradio merged 2 commits into
mainfrom
fix/composer-resize-width
Nov 10, 2026
Merged

kinqsradio merged 2 commits into
mainfrom
fix/composer-resize-width

Conversation

@luannn010

Copy link
Copy Markdown
Collaborator

Summary

  • Keep Ledger’s composer and transcript in their column beside the full-height details rail, including while Diff resizes across the former 1322px cutoff.
  • Add a truthful Ledger preview driven through existing Settings controls.

Refs #272: reproduced current Ledger case; historical Console/macOS cause unverified.

Parity rows

none

Frames built

Frames built: shell-ledger

The published design assigns no numeric version.

Testing

  • 10 focused browser cases; 19 preview-contract tests; type/lint and production build passed.
  • Light, Dark and Dim screenshots inspected.
  • Windows mock browser verified; packaged macOS and real engines untested.

Risk: Ledger horizontal alignment. Rollback: revert the layout commit.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Codex desktop / Codex CLI 0.160.0; native agents, PowerShell, Python, Git/GitHub CLI, npm, Vitest and Playwright headless shell revision 1248.
  • Models: gpt-6.1-sol (configured lead, runtime ID not exposed; independent source review), gpt-6.1-terra (reproduction, implementation and verification), gpt-6-luna (read-only source and preview mapping).
  • Effort: medium for all configured roles.
  • Human role: selected the issue, set scope and Codex-only delivery; human review and merge remain pending.
  • Sources: issue #272; published Engineer Designs, frame shell-ledger (user-owned design, no numbered version assigned; inspected without copying artifact code). No third-party source copied.

Checklist

  • Works on Windows and macOS (Windows browser checked; native macOS unverified)
  • web/src/generated with any contract change; docs/architecture.md with any rule change (neither changed)
  • No copied source, secrets, credentials or personal data; no AI attribution in commits, title or branch

@luannn010
luannn010 requested a review from kinqsradio as a code owner November 8, 2026 12:18
@github-actions github-actions Bot added area: web web: React UI area: docs docs and Markdown files labels Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

UI preview

Frames built: 1 drawn from the dev-only mock app (fake data, no account), commit 889e042. Light first; Dark and Dim are folded. This shows our screens only, not the designs.

shell-ledger

shell-ledger, Light

Dark and Dim

Dark

shell-ledger, Dark

Dim

shell-ledger, Dim

Every image, as one download: this workflow run.

@luannn010

Copy link
Copy Markdown
Collaborator Author

@kinqsradio Ready for review: the Ledger composer/details-rail fix is green on 889e042. All eight E2E shards, Web, preview, CodeQL and contribution checks passed. Independent Codex review and Light/Dark/Dim inspection are complete. This addresses the reproduced current Ledger case in #272; the original packaged macOS symptom remains unverified.

@kinqsradio kinqsradio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff against current main; the change is scoped and the checks are green. Merging with a merge commit.

@kinqsradio
kinqsradio merged commit e6adc41 into main Nov 10, 2026
29 checks passed
@kinqsradio
kinqsradio deleted the fix/composer-resize-width branch November 10, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs docs and Markdown files area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants