Skip to content

feat(engines): see the CLIs' tools and connectors, with approvals - #363

Merged
kinqsradio merged 9 commits into
mainfrom
feat/engine-tools-parity
Nov 8, 2026
Merged

kinqsradio merged 9 commits into
mainfrom
feat/engine-tools-parity

Conversation

@kinqsradio

Copy link
Copy Markdown
Member

Summary

  • Engine children no longer inherit the dev login switches (USE_LOCAL_OAUTH, USE_STAGING_OAUTH) or, under a host Claude session, its ANTHROPIC_BASE_URL; those made claude -p load no claude.ai connectors.
  • Claude runs record the init frame's MCP servers and plugins by name (engine.tools), and ask for every connector tool through our permission tool, even one the person allowed in their own settings.
  • Codex: our server uses the dotted key so a user server keeps its fields, optional servers get a 10 s startup grace, connector and MCP-tool elicitations go through the approval flow, and the model is told connectors are reachable from exec.

Closes #

Parity rows

none

Frames built

Frames built: none

Testing

  • CI covers the rest.
  • Live, real orbynd on a throwaway data dir, cheap models: Claude (Haiku) calling mcp__claude_ai_Claude_Docs__guide raised an approval ("Use mcp__claude_ai_Claude_Docs__guide") in our flow. A direct matrix on 2.1.318 showed permissions.ask beats allow for the server form, mcp__claude_ai_* and mcp__*. Codex (gpt-5.6-luna) completes with the new config; from exec, 314 mcp__ tools were reachable, 64 of them ours.
  • The init frame of a run with --mcp-config lists only our server; claude.ai connectors connect afterwards, so the init list under-reports them. The tools UI needs a probe (claude mcp list), not the frame alone.
  • Not tested: packaged app; Codex connector approval against a real connector.
  • Risks: startup grace can add up to 10 s before a first turn; user MCP servers run in the checkout; only server names are logged.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Claude Code
  • Models: claude-sonnet-5-5 (all)
  • Effort: low
  • Human role: set the task and acceptance
  • Sources: T3 Code (MIT), https://github.com/pingdotgg/t3code: reviewed for ideas, no code copied

Checklist

  • Works on Windows and macOS
  • web/src/generated with any contract change; docs/architecture.md with any rule change
  • No copied source, secrets, credentials or personal data; no AI attribution in commits, title or branch

@github-actions github-actions Bot added area: core crates/orbyn-core: runs, drivers, workspace, approvals, storage area: service crates/orbynd: local service and CLI labels Nov 8, 2026
@kinqsradio
kinqsradio merged commit 32eb049 into main Nov 8, 2026
28 checks passed
@kinqsradio
kinqsradio deleted the feat/engine-tools-parity branch November 8, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core crates/orbyn-core: runs, drivers, workspace, approvals, storage area: service crates/orbynd: local service and CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant