Repository navigation
feat(engines): see the CLIs' tools and connectors, with approvals - #363
Merged
Merged
Conversation
…k for every connector tool through our permission tool
… and elicitations go through the approval flow; tell the model connectors live in exec
…rry the approval guard
…rule for the plan and the login report
…name server and tool, grace is 3 s; bound the seen servers
… works on a CLI that ignores the wildcard
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USE_LOCAL_OAUTH,USE_STAGING_OAUTH) or, under a host Claude session, itsANTHROPIC_BASE_URL; those madeclaude -pload no claude.ai connectors.engine.tools), and ask for every connector tool through our permission tool, even one the person allowed in their own settings.exec.Closes #
Parity rows
none
Frames built
Frames built: none
Testing
orbyndon a throwaway data dir, cheap models: Claude (Haiku) callingmcp__claude_ai_Claude_Docs__guideraised an approval ("Use mcp__claude_ai_Claude_Docs__guide") in our flow. A direct matrix on 2.1.318 showedpermissions.askbeatsallowfor the server form,mcp__claude_ai_*andmcp__*. Codex (gpt-5.6-luna) completes with the new config; fromexec, 314mcp__tools were reachable, 64 of them ours.--mcp-configlists only our server; claude.ai connectors connect afterwards, so the init list under-reports them. The tools UI needs a probe (claude mcp list), not the frame alone.Co-authors
none
AI usage
Checklist
web/src/generatedwith any contract change;docs/architecture.mdwith any rule change