Skip to content

fix(e2e): wait for preview documents to finish loading - #357

Merged
kinqsradio merged 1 commit into
mainfrom
fix/preview-title-refresh
Nov 10, 2026
Merged

kinqsradio merged 1 commit into
mainfrom
fix/preview-title-refresh

Conversation

@luannn010

@luannn010 luannn010 commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Wait for fixture load acknowledgements, request counts and titles before further preview input.
  • Add a controlled pending-resource regression and failure diagnostics; retain real CDP input and existing deadlines.

Related #339. This hardens test readiness; the historical failure's cause remains unproven.

Risk/rollback: fixture readiness or held-resource cleanup could regress; revert this spec commit.

Parity rows

none

Frames built

Frames built: none

Testing

  • Type/lint checks and production build pass.
  • The controlled regression fails with the old title-only gate and passes with the load acknowledgement.
  • Windows dev mode under continuous CPU load: target 20/20 and full spec 80/80; zero skips or retries.
  • Not tested: macOS locally or real providers.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Codex 0.160.0; PowerShell/.NET, Python, Git, GitHub CLI, npm, Playwright, Cargo/Rust 1.99.1 and MSVC.
  • Models: gpt-6.1-sol (investigation, test implementation, local verification and separate actual-diff review); gpt-6-luna (coordinator's bounded public issue/comment/linked-PR metadata extraction only).
  • Effort: medium for both models.
  • Human role: Selected the issue and delivery scope; retains final review and merge.
  • Sources: Issue #339, reported CI run, existing repository source. No external code copied.

Checklist

  • Works on Windows and macOS
  • web/src/generated with any contract change; docs/architecture.md with any rule change
  • No copied source, secrets, credentials or personal data; no AI attribution in commits, title or branch

@luannn010
luannn010 requested a review from kinqsradio as a code owner November 8, 2026 08:04
@github-actions github-actions Bot added the area: web web: React UI label Nov 8, 2026
@luannn010

Copy link
Copy Markdown
Collaborator Author

@kinqsradio ready for review at ec5d419f: all current-head checks, including CLA, are green. Related #339: this hardens fixture load readiness and restores the real-input test; the historical cause remains unproven. Local loaded qualification passed 20 isolated + 80 shared-spec cases, zero skips/retries, with independent diff review. Hosted Web and all eight E2E execution steps passed; native/platform lanes were path-gated.

@kinqsradio kinqsradio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff against current main; the change is scoped and the checks are green. Merging with a merge commit.

@kinqsradio
kinqsradio merged commit eaf2c90 into main Nov 10, 2026
33 checks passed
@kinqsradio
kinqsradio deleted the fix/preview-title-refresh branch November 10, 2026 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants