Skip to content

fix(windows): launch scripted test engines through node - #349

Merged
kinqsradio merged 1 commit into
mainfrom
fix/scripted-engine-launch
Nov 10, 2026
Merged

kinqsradio merged 1 commit into
mainfrom
fix/scripted-engine-launch

Conversation

@luannn010

@luannn010 luannn010 commented Nov 8, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Launch Windows scripted test engines through Node-compatible entrypoints; retain POSIX shebang execution.
  • Add launch/protocol regressions and the Rust tests’ Node dependency.

Closes #336

Risk/rollback: test-launch or CI dependency regressions; revert the merge commit.

Parity rows

O27: functional Windows replay now passes; reference comparisons and quiet-machine qualification remain outstanding.

Frames built

Frames built: none

Testing

  • Windows: native regressions 3/3; unchanged O27 1/1, reaching END., zero retries.
  • Targeted Clippy, workspace formatting, web TypeScript and ESLint passed.
  • Independent review: no findings.
  • Not qualified: quiet-machine performance baseline or reference comparison.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Codex desktop 0.160.0; PowerShell, Python, Git/GitHub CLI, Rust/Cargo 1.99.1, Node 24.18.0, Playwright 1.64.1.
  • Models: gpt-6.1-sol implemented, investigated, verified and independently reviewed; gpt-6-luna extracted bounded public issue/comment/linked-PR intake metadata only.
  • Effort: medium for both models.
  • Human role: selected and authorized the issue delivery batch and constraints; retains merge approval. No human patch edits or code review claimed.
  • Sources: none; repository-owned code and issue evidence only, no external source copied.

Checklist

  • Works on Windows and macOS
  • No contract or architecture-rule changes
  • No copied source, secrets or personal data; no AI attribution outside this body

@luannn010
luannn010 requested a review from kinqsradio as a code owner November 8, 2026 06:58
@github-actions github-actions Bot added area: service crates/orbynd: local service and CLI area: web web: React UI area: ci CI, release and repository settings area: docs docs and Markdown files labels Nov 8, 2026
@luannn010

Copy link
Copy Markdown
Collaborator Author

@kinqsradio ready for review. All configured checks are green on f099d8d3aaefac39b9a3334085c0893b77405e41. The new native scripted-engine regressions ran and passed on Windows and macOS; the unchanged O27 browser case also passed on Windows and reached its final END message.

This fixes the Windows script-launch failure and declares the Node test dependency in Rust CI. Quiet-machine performance measurements and reference comparisons remain separate O27 work; no new benchmark numbers are claimed.

@kinqsradio kinqsradio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the diff against current main; the change is scoped and the checks are green. Merging with a merge commit.

@kinqsradio
kinqsradio merged commit 97d2f8a into main Nov 10, 2026
35 checks passed
@kinqsradio
kinqsradio deleted the fix/scripted-engine-launch branch November 10, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci CI, release and repository settings area: docs docs and Markdown files area: service crates/orbynd: local service and CLI area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(windows): scripted test engine fails to start (Win32 error 193)

2 participants