Repository navigation
fix(windows): launch scripted test engines through node - #349
Merged
Merged
Conversation
Collaborator
Author
|
@kinqsradio ready for review. All configured checks are green on This fixes the Windows script-launch failure and declares the Node test dependency in Rust CI. Quiet-machine performance measurements and reference comparisons remain separate O27 work; no new benchmark numbers are claimed. |
kinqsradio
approved these changes
Nov 10, 2026
kinqsradio
left a comment
Member
There was a problem hiding this comment.
Reviewed the diff against current main; the change is scoped and the checks are green. Merging with a merge commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #336
Risk/rollback: test-launch or CI dependency regressions; revert the merge commit.
Parity rows
O27: functional Windows replay now passes; reference comparisons and quiet-machine qualification remain outstanding.
Frames built
Frames built: none
Testing
END., zero retries.Co-authors
none
AI usage
Checklist