Repository navigation
fix(web): no text selection on the app chrome - #346
Merged
Merged
Conversation
UI previewThis pull request changes the web app but has no Frames built line. Add one to the description so the screens can be shown here: the ids of the screens you built and the design version, for example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
html,body,#root) now setsuser-select: none(plus-webkit-user-selectfor WKWebView) andcursor: default.user-select: text: transcript messages, markdown, code, tool output and commands, diffs, file previews, PR body, comments, review text, check names, patches, error text, copyable paths and ids, the terminal host, and every input, textarea and contenteditable. Inner elements that set none themselves (diff line numbers) stay unselectable.Not in this PR
Parity rows
none
Frames built
none
Testing
src/styles/selection.test.ts(root rule, WebKit spelling, the opt-in list, no pointer overrides).e2e/selection.spec.ts: a drag across a settings page selects nothing (fails without the stylesheet); a drag over a message selects its text; the composer stays selectable and editable.npm run -s check, style tests,Transcript.test.tsx,pane-resizee2e: pass.Co-authors
none
AI usage
Checklist