Skip to content

test(settings): fix flaky worktree cleanup and branch prefix tests - #345

Merged
kinqsradio merged 1 commit into
mainfrom
fix/settings-test-flakes
Nov 8, 2026
Merged

kinqsradio merged 1 commit into
mainfrom
fix/settings-test-flakes

Conversation

@kinqsradio

Copy link
Copy Markdown
Member

Summary

  • Two Settings tests failed on main CI (WorktreeCleanup days field, BranchNaming prefix preview) and once on feat(web): pull request list rows and detail states to the designs #322.
  • Cause: clear and type keystrokes into a field that is briefly disabled (the screen disables its controls while a read is under way) drop or reorder characters under load; the failure log showed 143 saved instead of 3.
  • Fix (tests only): wait until the field is enabled, set the value with one change event, blur it, and use findByText for the preview. The components have no race of their own.

Not in this PR

  • Component changes.

Parity rows

none

Frames built

none

Testing

  • Both files, 10 runs under 10 busy CPU loops: no failures. Before the change I could not reproduce locally, so the cause is read from the CI log and not seen failing here.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Claude Code 2.1.318
  • Models: claude-sonnet-5-5 (implementation)
  • Effort: medium
  • Human role: asked for the fix; the lead session decided scope and reviews before merge
  • Sources: none

Checklist

  • Tests only

@github-actions github-actions Bot added the area: web web: React UI label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

UI preview

This pull request changes the web app but has no Frames built line.

Add one to the description so the screens can be shown here: the ids of the screens you built and the design version, for example Frames built: pr-list-failed, pr-detail-running @ v56. A pull request that draws nothing says Frames built: none. This is a request, not a check: nothing is blocked.

@kinqsradio
kinqsradio merged commit 2e02f9e into main Nov 8, 2026
27 checks passed
@kinqsradio
kinqsradio deleted the fix/settings-test-flakes branch November 8, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant