Skip to content

fix(desktop): one unified title bar on macOS - #344

Merged
kinqsradio merged 11 commits into
mainfrom
fix/desktop-titlebar
Nov 8, 2026
Merged

kinqsradio merged 11 commits into
mainfrom
fix/desktop-titlebar

Conversation

@kinqsradio

@kinqsradio kinqsradio commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Summary

  • macOS: the main window uses an overlay title bar with the native title hidden. Our web bar is the only bar; the traffic lights sit at x=16, y=16 (centred in the 44px bar, matching the designs).
  • Capabilities: core:window:allow-start-dragging and core:window:allow-internal-toggle-maximize, so empty bar space drags and double-click zooms. The startup page gets the same 44px drag strip.
  • The bar floats over every page; the page header carries title, chips and actions on its centre line. No bar title, no second row, in any layout.
  • Windows and Linux keep the native frame: the designs draw no window controls for them. A custom Windows chrome needs a design first.

Not in this PR

  • Windows/Linux custom window controls.
  • The preview window stays native.

Parity rows

none

Frames built

Engineer Designs v60: shell-reading, thread-details-reading (the single 44px bar); shell-console for the other layouts.

Testing

  • Rust unit tests in chrome.rs (3, per-OS frame and light centre line vs the CSS bar height): pass.
  • cargo fmt --all --check: pass.
  • npm run build -- --bundles app: pass.
  • Desktop clippy -D warnings: only error is the existing windows_shim dead-code in system.rs (unused off Windows), not in this diff. Not run: real-window screenshot (left to the coordinator).

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Claude Code 2.1.318
  • Models: claude-sonnet-5-5 (implementation)
  • Effort: medium
  • Human role: asked for one unified title bar; the lead session decided scope and reviews before merge
  • Sources: none

Checklist

  • No design change
  • Verified in a real macOS window

@github-actions github-actions Bot added the area: desktop desktop: Tauri shell, packaging and updates label Nov 8, 2026
@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

UI preview

This pull request changes the web app but has no Frames built line.

Add one to the description so the screens can be shown here: the ids of the screens you built and the design version, for example Frames built: pr-list-failed, pr-detail-running @ v56. A pull request that draws nothing says Frames built: none. This is a request, not a check: nothing is blocked.

@github-actions github-actions Bot added the area: web web: React UI label Nov 8, 2026
@kinqsradio
kinqsradio merged commit 5b7f38f into main Nov 8, 2026
25 checks passed
@kinqsradio
kinqsradio deleted the fix/desktop-titlebar branch November 8, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: desktop desktop: Tauri shell, packaging and updates area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant