Repository navigation
fix(desktop): one unified title bar on macOS - #344
Merged
Merged
Conversation
UI previewThis pull request changes the web app but has no Frames built line. Add one to the description so the screens can be shown here: the ids of the screens you built and the design version, for example |
1 of 3 tasks
…title of its own (v60)
…-code warning elsewhere
…, zoom on release; tooltip kept
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core:window:allow-start-draggingandcore:window:allow-internal-toggle-maximize, so empty bar space drags and double-click zooms. The startup page gets the same 44px drag strip.Not in this PR
Parity rows
none
Frames built
Engineer Designs v60: shell-reading, thread-details-reading (the single 44px bar); shell-console for the other layouts.
Testing
chrome.rs(3, per-OS frame and light centre line vs the CSS bar height): pass.cargo fmt --all --check: pass.npm run build -- --bundles app: pass.-D warnings: only error is the existingwindows_shimdead-code insystem.rs(unused off Windows), not in this diff. Not run: real-window screenshot (left to the coordinator).Co-authors
none
AI usage
Checklist