Repository navigation
fix: flaky tests found on main, with their causes - #341
Merged
Merged
Conversation
…e any path is read back from it
… agent turns it away as busy
…s; the test waits for the controls to rest
…f racing the app's reads
…say so when it stays busy
…ls without it; the e2e name says both halves
… the open thread is archived
…sits with the rest of the section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky tests seen on main in recent runs, each with the cause found.
outside_files(Rust): the refusal of a file with a second name depended on which hard-link name macOS reports; the link-count check now runs first, before any path is read back. Nothing leaked before; the refusal just came with a different message.preview-input-trace(quarantined): it did not reproduce;test.fixmewith issue Flaky e2e: preview-input-trace link navigation and same-URL reload (title stays on the old document) #339.Not in this PR
preview-input-trace(Flaky e2e: preview-input-trace link navigation and same-URL reload (title stays on the old document) #339).Parity rows
none
Testing
npm run -s check, 1447 unit tests,cargo fmtandclippy -D warnings, the affected specs twice.Risk:
outside_filescheck order (security fence), saved-sessions retry. Undo: revert the merge commit.Co-authors
none
AI usage
Checklist
web/src/generatedwith any contract change;docs/architecture.mdwith any rule change