Skip to content

fix: flaky tests found on main, with their causes - #341

Merged
kinqsradio merged 10 commits into
mainfrom
fix/flaky-tests
Nov 8, 2026
Merged

kinqsradio merged 10 commits into
mainfrom
fix/flaky-tests

Conversation

@kinqsradio

Copy link
Copy Markdown
Member

Summary

Fixes the flaky tests seen on main in recent runs, each with the cause found.

  • outside_files (Rust): the refusal of a file with a second name depended on which hard-link name macOS reports; the link-count check now runs first, before any path is read back. Nothing leaked before; the refusal just came with a different message.
  • Saved sessions (product bug): dev React StrictMode sends the capabilities request twice and the service lets one native operation per agent run at a time; the second was turned away as busy and the UI never asked again. The read now retries up to 6 times with a growing delay.
  • Worktree cleanup: turning cleanup on after Off starts at 7 (it could read the old typed number first); the unit test waits for the select to be enabled.
  • Archived banner test: archives the thread on the mock service before rendering.
  • preview-input-trace (quarantined): it did not reproduce; test.fixme with issue Flaky e2e: preview-input-trace link navigation and same-URL reload (title stays on the old document) #339.

Not in this PR

Parity rows

none

Testing

  • CI covers the rest.
  • Locally: npm run -s check, 1447 unit tests, cargo fmt and clippy -D warnings, the affected specs twice.
  • Not tested: most of these never failed locally, so the causes come from reading the code and CI logs, not from a reproduction.

Risk: outside_files check order (security fence), saved-sessions retry. Undo: revert the merge commit.

Co-authors

none

AI usage

  • Written by hand, with no AI
  • Harness and version: Claude Code 2.1.318
  • Models: claude-opus-5-5 (lead and review), claude-sonnet-5-5 (implementation)
  • Effort: medium
  • Human role: Anh set the scope.
  • Sources: none

Checklist

  • Works on Windows and macOS
  • web/src/generated with any contract change; docs/architecture.md with any rule change
  • No copied source, secrets, credentials or personal data; no AI attribution in commits, title or branch

@github-actions github-actions Bot added area: core crates/orbyn-core: runs, drivers, workspace, approvals, storage area: web web: React UI labels Nov 8, 2026
@kinqsradio
kinqsradio merged commit 0de6e1a into main Nov 8, 2026
26 checks passed
@kinqsradio
kinqsradio deleted the fix/flaky-tests branch November 8, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core crates/orbyn-core: runs, drivers, workspace, approvals, storage area: web web: React UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant