refactor(groth16-proofs): clean architecture, unified error type, shared prover core#6
Merged
Merged
Conversation
nol4lej
commented
Apr 8, 2026
nol4lej
commented
Member
- Add ProofError enum replacing String errors throughout the crate
- Add field.rs with generic from_decimal_str/from_hex_le, eliminating duplication
- Add prover.rs with prove_from_witness shared by native and WASM paths
- Add codec.rs for snarkjs JSON compression decoupled from the wasm module
- Fix num_public_signals bug in circuit.rs (was (witness.len()/100).clamp(1,10))
- Update generate_proof_from_witness to require explicit num_public_signals arg
- Rewrite wasm.rs and wasm/snarkjs_proof.rs as thin wrappers, no logic duplication
- Keep decimal_to_field/hex_to_field as backward-compat shims in utils.rs
- Remove stale shebang from generate-proof-from-witness binary
- Remove tautological test in proof.rs (assert_eq!(128, 128))
…red prover core - Add ProofError enum replacing String errors throughout the crate - Add field.rs with generic from_decimal_str<F>/from_hex_le<F>, eliminating duplication - Add prover.rs with prove_from_witness shared by native and WASM paths - Add codec.rs for snarkjs JSON compression decoupled from the wasm module - Fix num_public_signals bug in circuit.rs (was (witness.len()/100).clamp(1,10)) - Update generate_proof_from_witness to require explicit num_public_signals arg - Rewrite wasm.rs and wasm/snarkjs_proof.rs as thin wrappers, no logic duplication - Keep decimal_to_field/hex_to_field as backward-compat shims in utils.rs - Remove stale shebang from generate-proof-from-witness binary - Remove tautological test in proof.rs (assert_eq!(128, 128))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.