release: 0.90.1

.release-please-manifest.json

@@ -1,3 +1,3 @@
 {
-  ".": "0.90.0"
+  ".": "0.90.1"
 }

CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 0.90.1 (2025-01-31)
+
+Full Changelog: [v0.90.0...v0.90.1](https://github.com/orbcorp/orb-go/compare/v0.90.0...v0.90.1)
+
+### Bug Fixes
+
+* fix unicode encoding for json ([#413](https://github.com/orbcorp/orb-go/issues/413)) ([c516247](https://github.com/orbcorp/orb-go/commit/c5162474177d71695aea73341cb1e2802e88672d))
+
+
+### Chores
+
+* **internal:** codegen related update ([#411](https://github.com/orbcorp/orb-go/issues/411)) ([c816078](https://github.com/orbcorp/orb-go/commit/c816078d28d0101fe4c4bd3aa2bd6bd3568e7c38))
+
 ## 0.90.0 (2025-01-30)
 
 Full Changelog: [v0.89.1...v0.90.0](https://github.com/orbcorp/orb-go/compare/v0.89.1...v0.90.0)

README.md

@@ -22,7 +22,7 @@ Or to pin the version:
 <!-- x-release-please-start-version -->
 
 ```sh
-go get -u 'github.com/orbcorp/[email protected].0'
+go get -u 'github.com/orbcorp/[email protected].1'
 ```
 
 <!-- x-release-please-end -->

client_test.go

@@ -63,12 +63,12 @@ func TestRetryAfter(t *testing.T) {
 			},
 		}),
 	)
-	res, err := client.Customers.New(context.Background(), orb.CustomerNewParams{
+	_, err := client.Customers.New(context.Background(), orb.CustomerNewParams{
 		Email: orb.F("[email protected]"),
 		Name:  orb.F("My Customer"),
 	})
-	if err == nil || res != nil {
-		t.Error("Expected there to be a cancel error and for the response to be nil")
+	if err == nil {
+		t.Error("Expected there to be a cancel error")
 	}
 
 	attempts := len(retryCountHeaders)
@@ -100,12 +100,12 @@ func TestDeleteRetryCountHeader(t *testing.T) {
 		}),
 		option.WithHeaderDel("X-Stainless-Retry-Count"),
 	)
-	res, err := client.Customers.New(context.Background(), orb.CustomerNewParams{
+	_, err := client.Customers.New(context.Background(), orb.CustomerNewParams{
 		Email: orb.F("[email protected]"),
 		Name:  orb.F("My Customer"),
 	})
-	if err == nil || res != nil {
-		t.Error("Expected there to be a cancel error and for the response to be nil")
+	if err == nil {
+		t.Error("Expected there to be a cancel error")
 	}
 
 	expectedRetryCountHeaders := []string{"", "", ""}
@@ -132,12 +132,12 @@ func TestOverwriteRetryCountHeader(t *testing.T) {
 		}),
 		option.WithHeader("X-Stainless-Retry-Count", "42"),
 	)
-	res, err := client.Customers.New(context.Background(), orb.CustomerNewParams{
+	_, err := client.Customers.New(context.Background(), orb.CustomerNewParams{
 		Email: orb.F("[email protected]"),
 		Name:  orb.F("My Customer"),
 	})
-	if err == nil || res != nil {
-		t.Error("Expected there to be a cancel error and for the response to be nil")
+	if err == nil {
+		t.Error("Expected there to be a cancel error")
 	}
 
 	expectedRetryCountHeaders := []string{"42", "42", "42"}
@@ -163,12 +163,12 @@ func TestRetryAfterMs(t *testing.T) {
 			},
 		}),
 	)
-	res, err := client.Customers.New(context.Background(), orb.CustomerNewParams{
+	_, err := client.Customers.New(context.Background(), orb.CustomerNewParams{
 		Email: orb.F("[email protected]"),
 		Name:  orb.F("My Customer"),
 	})
-	if err == nil || res != nil {
-		t.Error("Expected there to be a cancel error and for the response to be nil")
+	if err == nil {
+		t.Error("Expected there to be a cancel error")
 	}
 	if want := 3; attempts != want {
 		t.Errorf("Expected %d attempts, got %d", want, attempts)
@@ -188,12 +188,12 @@ func TestContextCancel(t *testing.T) {
 	)
 	cancelCtx, cancel := context.WithCancel(context.Background())
 	cancel()
-	res, err := client.Customers.New(cancelCtx, orb.CustomerNewParams{
+	_, err := client.Customers.New(cancelCtx, orb.CustomerNewParams{
 		Email: orb.F("[email protected]"),
 		Name:  orb.F("My Customer"),
 	})
-	if err == nil || res != nil {
-		t.Error("Expected there to be a cancel error and for the response to be nil")
+	if err == nil {
+		t.Error("Expected there to be a cancel error")
 	}
 }
 
@@ -210,12 +210,12 @@ func TestContextCancelDelay(t *testing.T) {
 	)
 	cancelCtx, cancel := context.WithTimeout(context.Background(), 2*time.Millisecond)
 	defer cancel()
-	res, err := client.Customers.New(cancelCtx, orb.CustomerNewParams{
+	_, err := client.Customers.New(cancelCtx, orb.CustomerNewParams{
 		Email: orb.F("[email protected]"),
 		Name:  orb.F("My Customer"),
 	})
-	if err == nil || res != nil {
-		t.Error("expected there to be a cancel error and for the response to be nil")
+	if err == nil {
+		t.Error("expected there to be a cancel error")
 	}
 }
 
@@ -238,12 +238,12 @@ func TestContextDeadline(t *testing.T) {
 				},
 			}),
 		)
-		res, err := client.Customers.New(deadlineCtx, orb.CustomerNewParams{
+		_, err := client.Customers.New(deadlineCtx, orb.CustomerNewParams{
 			Email: orb.F("[email protected]"),
 			Name:  orb.F("My Customer"),
 		})
-		if err == nil || res != nil {
-			t.Error("expected there to be a deadline error and for the response to be nil")
+		if err == nil {
+			t.Error("expected there to be a deadline error")
 		}
 		close(testDone)
 	}()

internal/apijson/encoder.go

@@ -143,7 +143,7 @@ func (e *encoder) newPrimitiveTypeEncoder(t reflect.Type) encoderFunc {
 	// code more and this current code shouldn't cause any issues
 	case reflect.String:
 		return func(v reflect.Value) ([]byte, error) {
-			return []byte(fmt.Sprintf("%q", v.String())), nil
+			return json.Marshal(v.Interface())
 		}
 	case reflect.Bool:
 		return func(v reflect.Value) ([]byte, error) {

internal/version.go

@@ -2,4 +2,4 @@
 
 package internal
 
-const PackageVersion = "0.90.0" // x-release-please-version
+const PackageVersion = "0.90.1" // x-release-please-version