-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: track progress #852
feat: track progress #852
Conversation
Discussions should go to #839 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
+ Coverage 75.72% 75.78% +0.05%
==========================================
Files 63 65 +2
Lines 6011 6087 +76
==========================================
+ Hits 4552 4613 +61
- Misses 1078 1090 +12
- Partials 381 384 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
Signed-off-by: Shiwei Zhang <[email protected]>
This PR is stale because it has been open for 45 days with no activity. Remove the stale label or comment to prevent it from being closed in 30 days. |
@shizhMSFT any progress on this? |
@deitch I have good news and bad news for this track progress effort. The good news is that we have this package integrated in the The bad news is that the code / design in this PR does not match the quality for generic use in
Therefore, I'd like to abandon this PR and try to find a better design for the Our overall strategy for having a new package in |
That makes sense, keeps the core critical library more robust.
The bad news is it is not in core, the good news is that, the same way CLI got it, I could get the same effect by adding my own code like CLI? I looked at the code, I could not quite figure out how I would leverage it. How would I hook it into an |
Important
This PR resolves #839 and is experimental.
This PR is also a duplicate of the
internal/progress
package in oras-project/oras#1524.This PR introduce a new package
progress
to track the progress of reading content.