Fixing a bug in IntArrayContainer.merge and adding tests #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod and the others.
oracle-contributor-agreement
bot
added
the
OCA Verified
Common/Trees/src/main/java/org/tribuo/common/tree/impl/IntArrayContainer.java
Show resolved
Hide resolved
JackSullivan
previously approved these changes
Dec 17, 2024
Craigacp
added a commit
that referenced
this pull request
Dec 22, 2024
* Fixing a bug in IntArrayContainer.merge and adding tests for that method and the others. * Fixing tests. * Review fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The merge method should not duplicate inputs, which can lead to issues in the regression trees which use that method.
Motivation
Fix for #383 and more tests for
IntArrayContainer.