generated from oracle/template-repo
-
Notifications
You must be signed in to change notification settings - Fork 29
feat: add pypi attestation discovery #1067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2df212b
to
6d7cf95
Compare
tromai
reviewed
Apr 29, 2025
tromai
reviewed
Apr 30, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 2, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 6, 2025
tromai
reviewed
May 7, 2025
tromai
reviewed
May 7, 2025
tromai
reviewed
May 7, 2025
tromai
requested changes
May 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have finished my round of review. Thank you.
tromai
reviewed
May 8, 2025
tromai
previously approved these changes
May 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for addressing the feedbacks.
behnazh-w
previously approved these changes
May 12, 2025
aee8b44
to
2620a0a
Compare
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
2620a0a
to
57f4346
Compare
tromai
approved these changes
May 12, 2025
behnazh-w
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds discovery of PyPI attestation. URLs to these attestation files are sought via the deps.dev API.
Description of changes
DepsDevRepoFinder
was updated to use theDepsDevService
, ensuring consistent and easily configurable use of the APIDepsDevRepoFinder
functions (they were not added previously), including for the functions that PyPI attestation discovery relies upon.pypi-attestation
is used to extract information from the attestation certificate. This information is coerced into a predicate for use elsewhere within Macaron.ultralytics
Python library as its target.Related issues
Closes #947