FixTestNIRun Gradle task to resolve test failures on Native Image run #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created MetadataGenerationUtils utility class for operations shared by ContributionTask and GenerateMetadataTask.
kimeta
force-pushed
the
mm/introduce-fixTestNIRun-task
branch
from
8454626 to
0ae9765
Compare
kimeta
changed the title
vjovanov
reviewed
Nov 22, 2025
| task.setGroup(METADATA_GROUP) | ||
| } | ||
| // gradle fixTestNIRun --testLibraryCoordinates=<maven-coordinates> --newLibraryVersion=<library version which needs fix> | ||
| tasks.register("fixTestNIRun", FixTestNativeImageRun.class) { task -> |
Member
There was a problem hiding this comment.
Give it a more descriptive name.
vjovanov
reviewed
Nov 22, 2025
| import java.util.List; | ||
| import java.util.stream.Collectors; | ||
|
|
||
| public abstract class GenerateMetadataTask extends DefaultTask { |
| import java.nio.file.Path; | ||
| import java.util.regex.Pattern; | ||
|
|
||
| public abstract class FixTestNativeImageRun extends DefaultTask { |
|
|
||
| @Option(option = "coordinates", description = "Coordinates in the form of group:artifact:version") | ||
| public void setCoordinates(String coordinates) { | ||
| this.coordinates = coordinates; |
Member
There was a problem hiding this comment.
We have CoordinateUtils now and they should be handled correctly.
| } | ||
|
|
||
| @Option(option = "allowedPackages", description = "Comma separated allowed packages (or - for none)") | ||
| public void setAllowedPackages(String allowedPackages) { |
Member
There was a problem hiding this comment.
Isn't this set in index.json? We override here?
| * Executes the given executable with arguments in an optional working directory via Gradle ExecOperations. | ||
| * Captures output and throws a RuntimeException if the exit code is non-zero. | ||
| */ | ||
| public static void invokeCommand(ExecOperations execOps, String executable, List<String> args, String errorMessage, Path workingDirectory) { |
Member
There was a problem hiding this comment.
These are general utils. Is there a lib that can do that?
| // Ensure the tests build.gradle has an agent block; if not, create user-code-filter.json and add the agent block. | ||
| Path buildFilePath = testsDirectory.resolve("build.gradle"); | ||
| if (!Files.isRegularFile(buildFilePath)) { | ||
| throw new RuntimeException("Cannot find tests build file at: " + buildFilePath); |
Member
There was a problem hiding this comment.
GradleException, we should also add this to AGENTS.md.
| throw new RuntimeException("Cannot find tests build file at: " + buildFilePath); | ||
| } | ||
| String buildGradle = Files.readString(buildFilePath, java.nio.charset.StandardCharsets.UTF_8); | ||
| boolean hasAgentBlock = Pattern.compile("(?s)\\bagent\\s*\\{").matcher(buildGradle).find(); |
| String buildGradle = Files.readString(buildFilePath, StandardCharsets.UTF_8); | ||
| boolean hasAgentBlock = Pattern.compile("(?s)\\bagent\\s*\\{").matcher(buildGradle).find(); | ||
| if (hasAgentBlock) { | ||
| InteractiveTaskUtils.printUserInfo("Agent block already present in: " + BUILD_FILE + " - skipping"); |
| If you already have the test project structure in this repository and need to generate or regenerate metadata, use the `generateMetadata` task: | ||
|
|
||
| ```shell | ||
| ./gradlew generateMetadata --coordinates=com.example:my-library:1.0.0 |
Member
There was a problem hiding this comment.
Add these to DEVELOPING.md and to testAllParallel.
| /** | ||
| * Creates index.json inside the given version directory, listing all files present in that directory. | ||
| */ | ||
| public static void createIndexJsonSpecificVersion(Path metadataDirectory) throws IOException { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements: #786
This task runs the Java agent on failed tests for a new library version, and creates a version-specific metadata directory.
It will be executed by automation script #769 to update the metadata for each failing library version.