Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GR-32682] [GR-52145] Add initial version of the Bytecode DSL. #9556

Open
wants to merge 140 commits into
base: master
Choose a base branch
from
Open

[GR-32682] [GR-52145] Add initial version of the Bytecode DSL. #9556

wants to merge 140 commits into from

Conversation

graalvmbot
Copy link
Collaborator

@graalvmbot graalvmbot commented Aug 23, 2024 •
edited by chumer
Loading

This pull request introduces Bytecode DSL, a new framework for implementing bytecode interpreters. Bytecode DSL consumes a user-provided specification (including a set of node-like operations) to generate a bytecode interpreter.

Tips for reviewing:

  1. The first commit is the one of interest. The next two two commits are migration code, and the ones after are bug/gate/feedback fixes (which will be squashed into the first commit before merge). It may be helpful to read some of the docs and tutorials to get started.
  2. The generated code is intended to be human readable, so it may be helpful to check out and build the test interpreters directly if you wish to look at generated code.
  3. @Bind.DefaultExpression was added in this PR. The changes are (unfortunately) too entangled with Bytecode DSL to easily pull out, so some of the changes here just remove redundant bind expressions.

Also read the changelog: https://github.com/oracle/graal/pull/9556/files#diff-0152a89226e848ea31c4005b3c57079db79ff8112c4278d28237c8b9ed24dc16

Features:

  • Tiered Interpretation (uncached -> cached)
  • Boxing elimination + Quickening
  • Reparsing (Lazy sources and Instrumentation)
  • Serialization/Deserialization
  • Coroutines
  • Tag and Bytecode Based Instrumentation
  • Local or Global Scoping of Variables
  • AST node proxying (for migration)
  • Several Tutorials & Guides

Continuation from:
#6697

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Aug 23, 2024
@graalvmbot graalvmbot force-pushed the mdsouza/GR-32682-bytecode-dsl branch from b40cfe9 to 9e57dc7 Compare August 28, 2024 14:52
@graalvmbot graalvmbot changed the title [GR-32682] Bytecode DSL [GR-32682][GR-52145] Add initial version of the Bytecode DSL. Sep 5, 2024
@chumer chumer mentioned this pull request Sep 26, 2024
Closed
@graalvmbot graalvmbot force-pushed the mdsouza/GR-32682-bytecode-dsl branch 2 times, most recently from 2288bd8 to ab347b2 Compare October 24, 2024 20:32
@graalvmbot graalvmbot changed the title [GR-32682][GR-52145] Add initial version of the Bytecode DSL. [GR-32682] [GR-52145] Add initial version of the Bytecode DSL. Nov 1, 2024
DSouzaM and others added 17 commits November 5, 2024 15:29
@DSouzaM @chumer @profMagija
Add Bytecode DSL
8e1219e 
Co-authored-by: Christian Humer <[email protected]>
Co-authored-by: Nikola Bebić <[email protected]>
@DSouzaM @chumer
Resolve DSL warnings/errors in Truffle & Languages code (dsl-warnings)
49ca9b0 
Co-authored-by: Christian Humer <[email protected]>
@DSouzaM @chumer @profMagija
Add Bytecode DSL interpreter to SimpleLanguage
b43c99d 
Co-authored-by: Christian Humer <[email protected]>
Co-authored-by: Nikola Bebić <[email protected]>
@DSouzaM
Fix: remove unnecessary assertion for uncheckedCast plugin
8af956f
@chumer @DSouzaM
Source materialization is no longer automatic and must be explicitly …
9c5fa3e 
…requested.
@chumer @DSouzaM
Port DSL benchmarks as tests to reproduce OSR issue.
21d1b4f
@DSouzaM
Fix test setup for OSR issue
e6d3ec4
@chumer @DSouzaM
Fix deopt loop with OSR.
66b6d4d
@chumer @DSouzaM
Improve compilation unit name for OSR compilations.
3aa2eab
@chumer @DSouzaM
Fix oldBc might be null for source to source translation.
65e19ff
@chumer @DSouzaM
Fix invalid old-style read from bytecode array.
2a0b2f9
@DSouzaM
Refactor: beginRoot(TruffleLanguage) to create/deserialize(ConcreteLa…
8c19bcd 
…nguage,...); remove language param from serialize
@DSouzaM
Refactor: require root node constructor parameter to have concrete la…
4e52cfb 
…nguage type
@DSouzaM
Fix: guard some code that shoud not be pulled in during compilation
cbe8745
@DSouzaM
Refactor: deduplicate GeneratorUtils#override and #overrideImplement
6397868
@DSouzaM
Code gen: directly generate branch profile code so checked/unchecked …
fb2454d 
…option is respected
@DSouzaM
Avoid deopt at OSR loop exit by forcing loop branch false profile >0;…
a5ed17e 
… improve grouping/ordering of instructions when transitioning to cached
chumer and others added 15 commits November 5, 2024 15:36
@chumer @DSouzaM
Sort builtin instructions by kind.
39ee861
@chumer @DSouzaM
Unsafely cast the frame type to avoid null checks in the loop.
957316b
@chumer @DSouzaM
Fix problem in manual bytecode.
04fded3
@chumer @DSouzaM
Fix ECJ compile error.
13e77ce
@chumer @DSouzaM
Fix several problems with boxing overloading.
6e826a2
@chumer @DSouzaM
Update instruction sizes.
f94db47
@chumer @DSouzaM
Revert sulong warning changes.
95d8fb9
@chumer @DSouzaM
Fix boxing overloads with primitives don't make sense. Re-resolve rep…
49f887a 
…laces after removal.
@chumer @DSouzaM
Fix use object array constant when possible.
78a7e7f
@DSouzaM
Make defaultUncachedThreshold an expression that can be configured at…
9f825b5 
… run time
@chumer @DSouzaM
Implement single specialization nodes without speculation don't need …
65e8831 
…a node.
@chumer @DSouzaM
Fix specialization grouping in cached initialization.
f48a007
@DSouzaM
More lint, signature, javadoc fixes; re-enable OSR
fbb015d
@DSouzaM
Only strip Node from the names of proxy nodes
0c85601
@DSouzaM
Replace neverPartOfCompilation with TruffleBoundary or deopt
961aa71
DSouzaM and others added 14 commits November 6, 2024 12:19
@DSouzaM
Run LSP tests using both SL interpreters
4181472
@DSouzaM
Run DAP tests using both SL interpreters
e2b15c5
@DSouzaM
Fix espresso DSL warnings (dsl-warnings)
7c443d0
@OracleLabsAutomation @DSouzaM
Update language imports
9e0e5ac
@DSouzaM
Fix compilation test after new extract boundary heuristics
2211f24
@DSouzaM
Minor lint fix
41812aa
@DSouzaM
Implement RootNode#computeSize
4ddb548
@DSouzaM
BytecodeNode: document parameters that should be PE const. Fix non-PE…
b67d79f 
… constant usages in tests.
@DSouzaM
Fix bug with stack walk in tracing test
dcdb47d
@DSouzaM
Insert deopt before uncached continueAt to prevent compilation failures
49a2255
@DSouzaM
Fix: LocalAccessorRange parameters should be PE constant
88db1dc
@DSouzaM
Reduce large local test to (attempt to) stay below loop explosion thr…
b5500d8 
…eshold
@DSouzaM
Reduce large stacktrace test to (attempt to) avoid compilation timeou…
7531a3a 
…t issues
@DSouzaM
Fix instruction partitioning: short circuit ops should always go in t…
4df8444 
…he main partition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chumer chumer

@DSouzaM DSouzaM

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
24.2.0 Release (March 18, 2025)
Development

Successfully merging this pull request may close these issues.
5 participants
@graalvmbot @fniephaus @chumer @DSouzaM @OracleLabsAutomation