Skip to content

COH-32325 - Fix issue with cache destroy when the stream handler has been closed #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025

Conversation

dhirupandey
Copy link
Member

No description provided.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 6, 2025
@dhirupandey dhirupandey requested a review from rlubke May 6, 2025 00:12
@dhirupandey
Copy link
Member Author

Do we need to close streamhandler once destroy is done?

    async def destroy(self) -> None:
        if not self._stream_handler._closed:
            dispatcher: Dispatcher = self._request_factory.destroy_request()
            await dispatcher.dispatch(self._stream_handler)
            await self._stream_handler.close()
        else:
            COH_LOG.info("Cache destroy cannot be done since the cache has been released")

rlubke
rlubke previously approved these changes May 6, 2025
Copy link

sonarqubecloud bot commented May 7, 2025

@dhirupandey dhirupandey merged commit 28eef32 into main May 7, 2025
27 checks passed
@dhirupandey dhirupandey deleted the COH-32325 branch May 7, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants