Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated compatibility check for aqua #952

Merged

Conversation

VipulMascarenhas
Copy link
Member

@VipulMascarenhas VipulMascarenhas commented Sep 21, 2024

Description

This PR covers the following:

  • add threaded decorator back to the load_config function.
  • add ui_compatability_check function that caches the compartment info.

Tests

> python -m pytest -q tests/unitary/with_extras/aqua/test_*
===================================================== test session starts ======================================================
platform darwin -- Python 3.8.19, pytest-7.4.4, pluggy-1.0.0
rootdir: /Users/user/workspace/git/accelerated-data-science
configfile: pytest.ini
plugins: Faker-26.0.0, cov-5.0.0, anyio-4.2.0, xdist-3.6.1
collected 230 items

tests/unitary/with_extras/aqua/test_cli.py ..............                                                                [  6%]
tests/unitary/with_extras/aqua/test_common_handler.py ...                                                                [  7%]
tests/unitary/with_extras/aqua/test_config.py .                                                                          [  7%]
tests/unitary/with_extras/aqua/test_decorator.py ..........                                                              [ 12%]
tests/unitary/with_extras/aqua/test_deployment.py .....................                                                  [ 21%]
tests/unitary/with_extras/aqua/test_deployment_handler.py ..s......                                                      [ 25%]
tests/unitary/with_extras/aqua/test_evaluation.py .............................                                          [ 37%]
tests/unitary/with_extras/aqua/test_evaluation_handler.py .........                                                      [ 41%]
tests/unitary/with_extras/aqua/test_evaluation_service_config.py .....................                                   [ 50%]
tests/unitary/with_extras/aqua/test_finetuning.py .......                                                                [ 53%]
tests/unitary/with_extras/aqua/test_finetuning_handler.py .....                                                          [ 56%]
tests/unitary/with_extras/aqua/test_global.py ...                                                                        [ 57%]
tests/unitary/with_extras/aqua/test_handlers.py .................                                                        [ 64%]
tests/unitary/with_extras/aqua/test_model.py .......................                                                     [ 74%]
tests/unitary/with_extras/aqua/test_model_handler.py ..............                                                      [ 80%]
tests/unitary/with_extras/aqua/test_ui.py ...............                                                                [ 87%]
tests/unitary/with_extras/aqua/test_ui_handler.py ..............                                                         [ 93%]
tests/unitary/with_extras/aqua/test_ui_websocket_handler.py ....                                                         [ 95%]
tests/unitary/with_extras/aqua/test_utils.py ...........                                                                 [100%]

=============================================== 229 passed, 1 skipped in 28.40s ================================================

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 21, 2024
ads/aqua/extension/utils.py Show resolved Hide resolved
@VipulMascarenhas VipulMascarenhas merged commit 5b4d2d3 into feature/aqua-v1.0.4 Sep 23, 2024
1 of 2 checks passed
@VipulMascarenhas VipulMascarenhas deleted the thread_cache_compatibility_check branch September 23, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants