Fix validation for model containing both formats. #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-ohai
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
VipulMascarenhas
approved these changes
Sep 20, 2024
mrDzurb
approved these changes
Sep 20, 2024
| @@ -933,139 +933,186 @@ def _validate_model( | |||
| # now as we know that at least one type of model files exist, validate the content of oss path. | |||
| # for safetensors, we check if config.json files exist, and for gguf format we check if files with | |||
| # gguf extension exist. | |||
| for model_format in model_formats: | |||
| if ModelFormat.SAFETENSORS in model_formats and ModelFormat.GGUF in model_formats: | |||
There was a problem hiding this comment.
This case is only possible for the service models?
We probably can do something like this:
if {ModelFormat.SAFETENSORS, ModelFormat.GGUF}.issubset(set(model_formats)):
Ideally we should come up with the base modelFormatValidator class, and implement different types of the format validators. We can do this in the next iteration.
| if ( | ||
| model_format == ModelFormat.SAFETENSORS | ||
| and len(safetensors_model_files) > 0 | ||
| import_model_details.inference_container == InferenceContainerTypeFamily.AQUA_LLAMA_CPP_CONTAINER_FAMILY |
There was a problem hiding this comment.
NIT:
import_model_details.inference_container.lower()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix validation for model containing both formats.
SAFETENSORSorGGUFformat and misses the case when both formats are present.Notebook
SAFETENSORSGGUFSelecting finetuning for GGUF model will fail
SAFETENSORSandGGUFSelecting finetuning for GGUF model will fail