Skip to content

Conversation

elizjo
Copy link
Member

@elizjo elizjo commented Sep 17, 2025

Description

Fixed a bug with extracting conda metadata during prepare artifacts.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 17, 2025
)
except Exception as e:
# not internet
logging.info("Obtaining service packs through bucket.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do sometihng like this:

    service_pack_path_mapping = {}
    service_pack_slug_mapping = {}

    try:
        service_pack_list = _get_index_json_through_bucket(
            namespace=namespace,
            bucketname=bucketname,
            auth=auth
        )
    except Exception as e:
        logger.error(
            "Failed to fetch service packs index from namespace '%s' and bucket '%s': %s",
            namespace,
            bucketname,
            str(e),
        )
        return service_pack_path_mapping, service_pack_slug_mapping

except Exception as e:
logging.warn(e)
logging.warn(
logging.warning(e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do:

except Exception as e:
        logger.error(
            f"Error occurred in attempt to extract the list of the service conda environments "
            f"from the object storage for bucket '{bucketname}' and namespace '{namespace}'. "
            f"Please make sure that you've provided correct bucket and namespace."
        )

mrDzurb
mrDzurb previously approved these changes Sep 17, 2025
mayoor
mayoor previously approved these changes Sep 17, 2025
@elizjo elizjo dismissed stale reviews from mayoor and mrDzurb via 07dc35b September 18, 2025 21:15
Copy link

📌 Cov diff with main:

Coverage-40%

📌 Overall coverage:

Coverage-58.39%

@mrDzurb mrDzurb merged commit 06dd598 into main Sep 19, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants