-
Notifications
You must be signed in to change notification settings - Fork 50
[AQUA] Track md logs for error logging #1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0a2725c
watching md predict/access logs for error
agrimk c9e40b9
watching logs and pushing them to telemetry
agrimk 4e97417
watching logs and pushing them to telemetry
agrimk 011a369
Merge branch 'main' into track_md_logs_for_error_logging
agrimk 06ccb9f
replaced async call with sync call
agrimk b802894
added deployment object in get_deployment_status method
agrimk 95e5a04
merge from master
agrimk b60cab7
fixed unit test of get_deployment_status
agrimk ba43d62
Merge branch 'main' into track_md_logs_for_error_logging
agrimk 83dc9fc
added test cases and PR review comments
agrimk ee3c9d0
Merge branch 'main' into track_md_logs_for_error_logging
agrimk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: any reason why we're removing the non-alphanumeric characters here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without removing the non-alphanumeric characters, I was getting bad request when calling the head_object endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you try encoding the characters using urllib.parse instead and see if that helps?
the missing characters is not a deal breaker, but can lead to not-so-readable output/message. If adding this also results in bad request, then we can go ahead with the change you've added.