Skip to content

Fix value of urlPattern in RegexParser#413

Open
pisces wants to merge 2 commits intooptonaut:masterfrom
pisces:bug/fix-url-pattern
Open

Fix value of urlPattern in RegexParser#413
pisces wants to merge 2 commits intooptonaut:masterfrom
pisces:bug/fix-url-pattern

Conversation

@pisces
Copy link
Copy Markdown

@pisces pisces commented Mar 30, 2022

Summary

  • Fixed the problem that other string after url are recognized as url
  • Add a file RegexParserTest.swift

Screenshot

Before After

@rromanchuk
Copy link
Copy Markdown

@pisces i just noticed that deep links like my-bundle-id://resource/id aren't picked up by the urlPattern, i tend to use them a lot in customer support context while on device, more reliable "user proofing" than a universal link.

Anyways, i guess i can add a custom handler. That NSRegularExpression escaping in the regexp string for URL makes it so much harder to decompose

@pisces
Copy link
Copy Markdown
Author

pisces commented Apr 2, 2022

@rromanchuk
I think the existing url pattern doesn't support custom scheme, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants