Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete order summary component #168

Open
wants to merge 9 commits into
base: order_summary_component
Choose a base branch
from

Conversation

mbashia
Copy link

@mbashia mbashia commented Aug 20, 2024

No description provided.

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font color and alignment

@mbashia mbashia requested a review from almirsarajcic August 23, 2024 02:08
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you see it now?
Screenshot 2024-08-23 at 10 12 02

Also, the component is not centered on mobile.
order_summary_component-mobile

@mbashia mbashia requested a review from almirsarajcic August 27, 2024 13:21
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some issue with screenshot generation for mobile that only happens in GitHub Actions. Otherwise, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants