Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete profile card component #167

Open
wants to merge 17 commits into
base: profile_card_component
Choose a base branch
from

Conversation

mbashia
Copy link

@mbashia mbashia commented Aug 20, 2024

No description provided.

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't match the design exactly. There are some alignment issues.

@mbashia mbashia requested a review from almirsarajcic August 23, 2024 02:58
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the difference?
Screenshot 2024-08-23 at 10 20 32
Screenshot 2024-08-23 at 10 21 07

challenges/profile_card_component/tailwind.config.js Outdated Show resolved Hide resolved
@mbashia mbashia requested a review from almirsarajcic August 27, 2024 12:54
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked the generated screenshots (https://github.com/optimumBA/frontend_mentor_challenges/actions/runs/10578520354)? The mobile one is empty.

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots get generated properly now.
Just remove the extra code and that's it.

challenges/profile_card_component/tailwind.config.js Outdated Show resolved Hide resolved
.github/workflows/cicd.yml Show resolved Hide resolved
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI misbehaves (screenshots). Otherwise, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants