Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat app css illustration #147

Open
wants to merge 9 commits into
base: chat_app_css_illustration
Choose a base branch
from
Open

Chat app css illustration #147

wants to merge 9 commits into from

Conversation

ngumokenneth
Copy link

chat_app_css_illustration-desktop
chat_app_css_illustration-mobile

almirsarajcic
almirsarajcic requested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big difference between the design proposal and this implementation. Also, images should be inside the challenge directory.

challenges/chat_app_css_illustration/index.html Outdated
<div class="mt-3">
<a
class="text-optimum-blue hover:text-optimum-darkblue"
href="https://github.com/optimumBA/frontend_mentor_challenges/tree/chat_app_css_illustration/challenges/chat_app_css_illustration"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put your username instead of optimumBA.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. I'll make the changes. Thanks.

almirsarajcic
almirsarajcic requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have some unnecessary file changes.
You shouldn't touch favicons. They aren't a part of challenges.

almirsarajcic
almirsarajcic requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI needs to be improved.

almirsarajcic
almirsarajcic approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@almirsarajcic almirsarajcic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI could be improved further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almirsarajcic almirsarajcic almirsarajcic approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngumokenneth @almirsarajcic