Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qr code component #143

Open
wants to merge 19 commits into
base: qr_code_component
Choose a base branch
from

Conversation

ngumokenneth
Copy link

qr_code_component-desktop
qr_code_component-mobile

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component doesn't match the design exactly. Check the margins and padding for the text.

Also, the image location is incorrect. Check other developers' PRs to see where the image should be put.

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image location is still incorrect. It should be inside challenges/qr_code_component/images directory.

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Looking at this, you can see the images directory should be a child of qr_code_component directory.

Copy link
Member

@almirsarajcic almirsarajcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have some unnecessary file changes.
You shouldn't touch favicons. They aren't a part of challenges.

@ngumokenneth
Copy link
Author

All right, I'll revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants