[FSSDK-11184] Update: Send CMAB uuid in impression events #458
+368
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt OptimizelyFactory
- test_optimizely.py fixed to expect new Decision objects
…er and decision service
… and ensure key is of bytes type in hash128
…add __init__.py for cmab module
…essages and add a test for handling 500 errors
…lt and updating get_variation return type to include detailed error information
-test cases changed to handle return type dicts of DecisionResult and VariationResult
…ated logic for improved variation handling
…or-cmab' into farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
…or-cmab' into farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
This reverts commit d2fc631.
…just related logic for improved variation handling" This reverts commit b901c5f.
…or-cmab' into farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
FarhanAnjum-opti
force-pushed
the
farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
branch
from
891aae9 to
73a2802
Compare
…or-cmab' into farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
…or-cmab' into farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
…or-cmab' into farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
…or-cmab' into farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
…or-cmab' into farhan-anjum/FSSDK-11184-update-impression-event-for-cmab
raju-opti
requested changes
Jul 17, 2025
tests/test_optimizely.py
Outdated
| variation = self.optimizely.get_variation('test_experiment', 'test_user') | ||
| self.assertEqual('variation', variation) | ||
|
|
||
| # Verify decision notification is sent with correct parameters |
There was a problem hiding this comment.
We need to also assert that the sent logx event contains the uuid in metadata.
…wo redundant tests on legacy api.
raju-opti
requested changes
Jul 18, 2025
tests/test_optimizely.py
Outdated
| opt_obj.decision_service, 'get_variations_for_feature_list', | ||
| return_value=[decision_result] | ||
| ), mock.patch( | ||
| 'optimizely.event.user_event_factory.UserEventFactory.create_impression_event' |
There was a problem hiding this comment.
instead of mocking this, we can use a custom event dispatcher and assert on the eventDispatcher.dispatch method arguments
raju-opti
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impression event updates related to CMAB.
Test plan
Added unit tests
Issues
FSSDK-11184