Skip to content

Conversation

raju-opti
Copy link
Contributor

@raju-opti raju-opti commented Sep 8, 2025

Summary

  • Currently, the notification payload types are exported from shared_types. But the current current types used in the notification center has diverged from these types, and these types are not used in the sdk. Therefore, the sdk user should not import/use these types either. But as these has been publicly released, we cannot change them in a incompatible manner either. So, updating these types as generic map to keep them backwards comptabile. Also exporting the actual payload types being used with new names. The user should use these new types instead.

Test plan

Issues

  • FSSDK-11823

@coveralls
Copy link

coveralls commented Sep 8, 2025

Coverage Status

coverage: 78.991%. first build
when pulling 7177687 on raju/more-type
into b9fb371 on master.

@raju-opti raju-opti merged commit f04de07 into master Sep 8, 2025
20 checks passed
@raju-opti raju-opti deleted the raju/more-type branch September 8, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants