[FSSDK-11529] Impression event logic adjustment for holdouts #1076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaed-optimizely
requested review from
raju-opti and
Copilot
and removed request for
raju-opti
junaed-optimizely
assigned
jaeopt and
muzahidul-opti and unassigned
jaeopt and
muzahidul-opti
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts the impression event logic to properly handle holdout decisions. Holdouts are now treated similarly to feature tests for impression event dispatching, ensuring that impression events are sent when users are assigned to holdout experiments.
- Added holdout decision source checks to impression event dispatch conditions
- Updated layer ID logic to exclude holdouts from layer ID lookup
- Enabled the holdout feature toggle
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/optimizely/index.ts | Added HOLDOUT decision source checks to impression event conditions |
| lib/optimizely/index.spec.ts | Added comprehensive test coverage for holdout impression events |
| lib/feature_toggle.ts | Enabled the holdout feature flag |
| lib/event_processor/event_builder/user_event.ts | Modified layer ID logic to exclude holdouts |
junaed-optimizely
deleted the
junaed/fssdk-11529-update-impression-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Event sending logic has been adjusted to accommodate holdouts
Test plan
New test cases have been added
Issues