[FSSDK-11159] lru cache impl update #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junaed-optimizely
requested review from
muzahidul-opti,
mikechu-optimizely and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Remove method to the LruCache implementation for CMAB support. The implementation provides thread-safe removal of cache entries by key.
- Adds a new
Remove(string key)method to the LruCache class with proper thread synchronization - Comprehensive test coverage including edge cases and thread safety scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| OptimizelySDK/Odp/LruCache.cs | Adds Remove method with thread-safe implementation |
| OptimizelySDK.Tests/OdpTests/LruCacheTest.cs | Adds comprehensive test coverage for the Remove method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
junaed-optimizely
deleted the
junaed/fssdk-11159-update-cache-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
LRU cache remove method addition for CMAB support
Test plan
Tests have been added
Issues
FSSDK-11159