-
Notifications
You must be signed in to change notification settings - Fork 44
3d Visualizations of optimization problems #581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Modularized code into distinct functions for preprocessing, evaluation, and plotting. - Introduced `_plot_slice` and `_plot_pairwise` to handle different projection types. - Simplified and optimized logic for generating grid and evaluation points. - Improved code readability by removing redundant code and separating responsibilities.
…ion components for improved modularity and maintainability. Added documentation strings for function definition on plot_data.py.
- Added detailed docstrings to improve clarity and usability - Made minor changes to code structure for better readability and maintainability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Thanks for the PR!
Before I start a thorough review of your changes, lets tackle some high-level issues:
- Can you move the code from
plot_data.py
into theslice_plot.py
module, unless it is also used in other plotting functions. - Can you re-order the functions such that the function that is exported by the module (slice_plot) is at the beginning, then the private slice plot functions, and lastly the plotting data code.
- Can you create a small notebook where you showcase the usage of the new features (this does not need to pushed, you can just upload it in a comment here).
Thanks a lot! If you have any questions, let me know here or on Zulip!
Hey @timmens, Thanks for the feedback! Sure, I’ll move the code from I'll work on a small notebook to demonstrate the new features and share it here once it’s ready. Also, I’ll take this opportunity to improve the modularity of the plotting logic a bit—cleaning it up should make the flow easier to understand. Let me know if there's anything else I should add or keep in mind! |
for more information, see https://pre-commit.ci
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…py, and a few bug fixes are done
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
Sandbox Version: These changes are added as a sandbox version of slice_plot. It can be imported using
om.sandbox.slice_plot_3d
Summary of changes
how_to_slice_plot_3d.ipynb
, with detailed examples and use cases to assist with adoption.Future Improvements
Note: An extensive parameter usage is provided in the attached notebook (Inside the .zip),
advanced_slice_plot_3d_usage.zip
. Example outputs are also included below in this comment.