Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance support data collection tool #5995

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

Enhance support data collection tool #5995

wants to merge 1 commit into from
+492 −17

Conversation

wartraxx51
Copy link
Contributor

This commit adds several major enhancements to the support data collection tool:

  • Add prometheus metrics collection at configurable intervals
  • Add benchmarking with system metrics analysis
  • Convert server info and pip packages to JSON format for better analysis
  • Add task manager Prefect API data collection
  • Add option to control log line collection volume (--log-lines)
  • Add option to disable benchmarking (--no-benchmark)
  • Fix collection issues in containerized environments

@wartraxx51 wartraxx51 force-pushed the jbr-v3-docker-collect-new-feature branch 2 times, most recently from 18b7643 to 5663d30 Compare March 11, 2025 11:04
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #5995 will not alter performance

Comparing jbr-v3-docker-collect-new-feature (f4a14be) with stable (4b05693)

Summary

✅ 10 untouched benchmarks

@wartraxx51 wartraxx51 force-pushed the jbr-v3-docker-collect-new-feature branch from 5663d30 to f4a14be Compare March 11, 2025 11:33
fatih-acar
fatih-acar reviewed Mar 14, 2025
View reviewed changes
tasks/container_ops.py
if any(
sensitive in key.lower() for sensitive in ["password", "secret", "token", "key"]
):
data[key] = "********"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can refactor this since you use that in multiple places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fatih-acar fatih-acar fatih-acar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wartraxx51 @fatih-acar