stop using local_rels/attrs in schema update #5595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group/backend
CodSpeed Performance ReportMerging #5595 will not alter performanceComparing Summary
|
ajtmccarty
force-pushed
the
ajtm-01272025-generic-extensions-bug
branch
from
c7250f3 to
9d1802b
Compare
|
Changes seem to affect any node update, not specifically a node loaded through
I am not familiar with extensions schemas though |
LucasG0
approved these changes
Jan 31, 2025
ajtmccarty
force-pushed
the
ajtm-01272025-generic-extensions-bug
branch
from
d54ddf3 to
ae160c9
Compare
ajtmccarty
force-pushed
the
ajtm-01272025-generic-extensions-bug
branch
from
ae160c9 to
67d02fc
Compare
dgarros
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IFC-1090
loading an extension of a schema that inherits a relationship from a generic can cause the inherited relationship on the schema to be deleted.
the PRs to fix IFC-1201 and IFC-1363 (#6074 and #6123) also fixed this issue. so this issue actually just adds a unit test to prove that it is fixed