Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert policy order #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Alert policy order #388

wants to merge 1 commit into from

Conversation

gdlx
Copy link

@gdlx gdlx commented Jun 30, 2023

This is an attempt to fix #223

It works perfectly if all policies are managed through this resource but mixing it with policies ordered throught the UI may lead to unpredictable behavior.

I tried some workarounds to add other policies order in the state to avoid systeamtic diff but I finally filtered the policies returned by the API to only handle those being managed by the resource. Other policies are just "ignored", and relative order between managed policies seems to be always correct.

I gave more info on API constraints in #223 discussion.

@gdlx gdlx changed the title [WIP] Alert policy order Alert policy order Aug 29, 2023
@gdlx
Copy link
Author

gdlx commented Aug 30, 2023

Any chance this could be reviewed ?

@koushik-swaminathan
Copy link
Contributor

Hi @gdlx, I recently release a new version v0.6.30 fixing this issue. Could you try out the this release and get back to me? Apologies for the time taken :)

@gdlx
Copy link
Author

gdlx commented Nov 16, 2023

Hi @koushik-swaminathan, I just tried the change in 0.6.30 (sorry for the delay), but it wasn't the same issue (note #223 wasn't listed in #390 list of fixed issues).

Can you please re-open my PR or should I open a new one ?

@gdlx gdlx force-pushed the alert_policy_order branch from df67e54 to 63c0fba Compare November 16, 2023 13:37
@gdlx
Copy link
Author

gdlx commented Nov 16, 2023

@koushik-swaminathan I've just rebased the PR.

I'm open to any other solution to handle policies order but the lack of this feature is a real blocker for me to use this provider, as I'm using dozen of policies, some of them being strongly order dependant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Control order of Alert Policies
2 participants