Allow zeroes in until_hour/until_minute under notification_policy.delay_action. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudo-thomas
force-pushed
the
rudo-pr-allow-zeroes-in-notification-policy-until
branch
from
6867d04 to
b274cac
Compare
…ay_action. The referenced issue opsgenie/opsgenie-go-sdk-v2#29 has been fixed.
rudo-thomas
force-pushed
the
rudo-pr-allow-zeroes-in-notification-policy-until
branch
from
b274cac to
fe5df0f
Compare
|
@frknyldz @skanda9999 @fnuva could you please approve and merge this? |
|
@d-mankowski-synerise can you please rebase this PR ? |
|
@arjunrajpal I can't, since this is not my feature branch. Opened #378 instead |
|
Closing this PR as we have taken @rudo-thomas's commit in #379 and merged the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The referenced issue
opsgenie/opsgenie-go-sdk-v2#29 has been fixed, hence the workaround in the code can be removed.