Refactor export method in BaseExporter.java

opsgenie · Aug 22, 2017 · 4db706f · 4db706f
1 parent f572133
commit 4db706f
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/main/java/com/opsgenie/tools/backup/exporters/BaseExporter.java b/src/main/java/com/opsgenie/tools/backup/exporters/BaseExporter.java
@@ -33,16 +33,17 @@ protected void exportFile(String fileName, T bean) {
 
     @Override
     public void export() {
-        List<T> currentBeanList = null;
+        List<T> currentBeanList;
         try {
             currentBeanList = retrieveEntities();
         } catch (Exception e) {
             logger.error("Error at Listing " + exportDirectory.getName(), e);
+            return;
+        }
+
+        for (T bean : currentBeanList) {
+            exportFile(getExportDirectory().getAbsolutePath() + "/" + getBeanFileName(bean) + ".json", bean);
         }
-        if (currentBeanList != null)
-            for (T bean : currentBeanList) {
-                exportFile(getExportDirectory().getAbsolutePath() + "/" + getBeanFileName(bean) + ".json", bean);
-            }
     }
 
     protected abstract String getBeanFileName(T bean);