New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed file descriptor leak #15

Open

ThrosturX wants to merge 1 commit into opsgenie:master from ThrosturX:master

ThrosturX commented Nov 18, 2019

Fixes issue #14 the easy way, leveraging the fact that cmd.Run() waits until the process has finished, thus closing the Stderr logger manually.

A possibly better fix would be the following, I guess it's up to the PO to decide.

writer := bufio.NewWriter(outfile)
defer writer.Flush()              
                                  
if err = cmd.Start(); err != nil {
    /* handle the error */
}                                 
go io.Copy(writer, stdoutBuff)

if err = cmd.Wait(); err != nil {
    /* handle the error */
}


          fixed file descriptor leak

1eb6be3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet