-
Notifications
You must be signed in to change notification settings - Fork 355
added support for optional clusterName via config file #173
Conversation
… events need a clustername when multiple clusters are in service
The build is failing because it needs a Maybe a 1 PR with nothing but mod tidy, and then a second one for this changeset would be easy to manage. A mod tidy is probably needed somewhere at this point. |
@xmcqueen Is it working for you. I built image from this PR , still i see empty string clustername.
|
Yes its in very heavy usage over here. It works great. I wonder if the problem is your use of Here's the annotation for the struct where the yaml is decoded: pkg/exporter/config.go +16
|
Thanks it works, Very sharp Eye. |
@xmcqueen can I open a PR with this code for the maintained fork here? https://github.com/resmoio/kubernetes-event-exporter |
wow I had no idea. Yes and maybe I'll jump over there too. I've got 2 PRs queued up here now. Thanks I need metrics in there. I've got a PR in here that adds prometheus metrics. Wow and the vendor directory is gone too! I was going to open a ticket about that! Yes, I'm jumping over to this new repo. You go ahead with the clusterName PR. I'll get the prometheus metrics PR going. |
When there are multiple clusters in an area its essential to have the event's clustername associated with each event. The event object exposed by Kubernetes provides a clustername, but it does not set it. This PR sets the clustername.
#167