This repository has been archived by the owner on Aug 31, 2022. It is now read-only.
avoid logging at the error level the errors involving CRD #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anyway at debug level
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kubernetes-event-exporter is deployed on a cluster with many CRD (custom resource definitions) and its default clusterrole doesn't account for them, it then starts logging a ton of errors and this can cause problems (like saturation of storage if you are ingesting your logs from the kubernetes cluster).
I think a better approach is to log errors involving CRD at the debugging level. So you can fix your clusterrole and avoid being overwhelmed by errors.