Ref #71 Jakarta migration#72
Conversation
| systemPackage("javax.transaction.xa;version=1.1.0"), | ||
| systemPackage("sun.misc"), | ||
| systemPackage("org.testcontainers.containers;version=1.19.3"), | ||
| systemPackage("org.testcontainers.utility;version=1.19.3"), |
There was a problem hiding this comment.
These should not be system packages.
There was a problem hiding this comment.
I haven't found another solutions to make it work with test container, try to add test containers bundle to the container, but never got it to work and PaxExam does not provide a way to do something outside of the container before the test. I've done something like this in camel-karaf, but here it just seemed simple to add this, unless you think there is a better solution.
|
Thanks for the PR - I've added some comments in the review. Do we really need .github/copilot-instructions.md? It contains contradictory statements from what you changed...
|
|
Thanks for the comments, I'll remove copilot instructions, they were not that useful anyway. |
c01e674 to
da4d273
Compare
|
Hello @grgrzybek , in order to restore transx feature, I created 2 PRs ops4j/org.ops4j.pax.transx#74 and apache/aries#790 to migrate them jakarta namespace as well |
0ade766 to
51523fb
Compare
fixes #71
Hello, this is an attempt to migrate to jakarta.
The biggest rock left is
pax-jms-pool-tranxbecausepax-trans-jmsdoesn't have jakarta version yet either.What is your opinion on it : migrate pax-trans-jmx to replace all geronimo dependencies to jakarta ?