Skip to content

Ref #71 Jakarta migration#72

Draft
f2par0 wants to merge 5 commits intoops4j:mainfrom
f2par0:fdeparscau/jakarta
Draft

Ref #71 Jakarta migration#72
f2par0 wants to merge 5 commits intoops4j:mainfrom
f2par0:fdeparscau/jakarta

Conversation

@f2par0
Copy link
Copy Markdown

@f2par0 f2par0 commented Jan 28, 2026

fixes #71

Hello, this is an attempt to migrate to jakarta.

  • moved to java 17
  • updated pom version to 2.0.0-SNAPSHOT
  • usage of test containers instead of embedded activemq/artemis to avoid conflicting javax dependencies

The biggest rock left is pax-jms-pool-tranx because pax-trans-jms doesn't have jakarta version yet either.

What is your opinion on it : migrate pax-trans-jmx to replace all geronimo dependencies to jakarta ?

Comment thread pax-jms-features/pom.xml Outdated
Comment thread pax-jms-features/pom.xml
Comment thread pax-jms-pool-narayana/pom.xml Outdated
Comment thread pom.xml
Comment thread pom.xml Outdated
Comment thread README.md Outdated
Comment thread pax-jms-itest/pom.xml Outdated
Comment thread pax-jms-itest/pom.xml Outdated
Comment thread pax-jms-features/src/main/resources/feature.xml Outdated
systemPackage("javax.transaction.xa;version=1.1.0"),
systemPackage("sun.misc"),
systemPackage("org.testcontainers.containers;version=1.19.3"),
systemPackage("org.testcontainers.utility;version=1.19.3"),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should not be system packages.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found another solutions to make it work with test container, try to add test containers bundle to the container, but never got it to work and PaxExam does not provide a way to do something outside of the container before the test. I've done something like this in camel-karaf, but here it just seemed simple to add this, unless you think there is a better solution.

@grgrzybek
Copy link
Copy Markdown
Member

grgrzybek commented Jan 29, 2026

Thanks for the PR - I've added some comments in the review.

Do we really need .github/copilot-instructions.md? It contains contradictory statements from what you changed...

  • JDK 11 vs 17
  • OSGi Framework Felix 5 (ancient)
  • DS annotations are good for applications, but not quite for libraries as this one
  • There's no Artemis 3.0
  • Write meaningful commit messages - when your commit messages are just attempt to fix integration tests - I don't like squashing commits, but two commits with the same message are not nice. Also commits should refer to an issue (like [#71])

@f2par0
Copy link
Copy Markdown
Author

f2par0 commented Jan 29, 2026

Thanks for the comments, I'll remove copilot instructions, they were not that useful anyway.
I squashed some commits, will do some cleanup when solution works completely

@f2par0
Copy link
Copy Markdown
Author

f2par0 commented Feb 5, 2026

Hello @grgrzybek , in order to restore transx feature, I created 2 PRs ops4j/org.ops4j.pax.transx#74 and apache/aries#790 to migrate them jakarta namespace as well

@f2par0 f2par0 force-pushed the fdeparscau/jakarta branch from 0ade766 to 51523fb Compare February 5, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jakarta

2 participants