Texture: add disableSRGBInternalFormat flag to prevent shader recomplie#133
Open
JichenZhang wants to merge 1 commit intooppenfuture:r137-devfrom
Open
Texture: add disableSRGBInternalFormat flag to prevent shader recomplie#133JichenZhang wants to merge 1 commit intooppenfuture:r137-devfrom
JichenZhang wants to merge 1 commit intooppenfuture:r137-devfrom
Conversation
…iation for RenderTargets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a flag called "disableSRGBInternalFormat" to Texture instances.
If the flag is set to true, we prevent using gl's sRGB internal format, so that the output format of a shader becomes sRGB, which is consistent with what the sceen expects. Thus, we prevent shader recompliation when using a WebGLRenderTarget rather than the screen - the already compiled shaders (who was serving the screen in the beginning) can be used.