opnsense-beep: serialize access to /dev/speaker #8281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise one of concurrent calls to `beep' might fail with error message
"beep: open of /dev/speaker for writing: Device busy".
Locking is done in `opnsense-beep' and not in `beep' to preserve tune (avoid
cacophony). ${BEEPDIR}/low is used as a lock-file as `low' beep is already a
special file: it's default beep.
This might sound like a trivial change, but it might affect system behavior,
e.g. when `opnsense-beep' is used in some shell script with errexit enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise one of concurrent calls to `beep' might fail with error message "beep: open of /dev/speaker for writing: Device busy".
Locking is done in
opnsense-beepand not inbeepto preserve tune (avoid cacophony). ${BEEPDIR}/low is used as a lock-file as `low' beep is already a special file: it's default beep.This might sound like a trivial change, but it might affect system behavior, e.g. when `opnsense-beep' is used in some shell script with errexit enabled.