Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): api update #184

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Conversation

artek-koltun
Copy link
Contributor

No description provided.

@artek-koltun artek-koltun force-pushed the api-update branch 3 times, most recently from 3a7443d to 84e30b1 Compare February 7, 2024 09:13
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 469 lines in your changes are missing coverage. Please review.

Comparison is base (36882b8) 34.92% compared to head (e10d0ab) 34.76%.

Files Patch % Lines
pydpu/proto/v1/frontend_nvme_pb2.py 1.87% 262 Missing ⚠️
pydpu/proto/v1/ipsec_pb2.py 4.50% 106 Missing ⚠️
pydpu/proto/v1/opicommon_pb2.py 7.93% 58 Missing ⚠️
pydpu/proto/v1/inventory_pb2.py 16.12% 26 Missing ⚠️
pydpu/proto/v1/ipsec_pb2_grpc.py 28.57% 10 Missing ⚠️
pydpu/ipsec.py 14.28% 6 Missing ⚠️
pydpu/proto/v1/inventory_pb2_grpc.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   34.92%   34.76%   -0.17%     
==========================================
  Files          27       26       -1     
  Lines        1947     1936      -11     
==========================================
- Hits          680      673       -7     
+ Misses       1267     1263       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@artek-koltun artek-koltun marked this pull request as ready for review February 7, 2024 09:18
@artek-koltun artek-koltun requested a review from a team as a code owner February 7, 2024 09:18
@artek-koltun artek-koltun force-pushed the api-update branch 2 times, most recently from 0dee396 to e10d0ab Compare February 8, 2024 08:47
Instead of full resource names, relative resource names are used.

Signed-off-by: Artsiom Koltun <[email protected]>
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandersms sandersms merged commit d28a1cd into opiproject:main Feb 8, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants