Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codedup: start using aip-go #434

Merged
merged 1 commit into from
Jun 6, 2023
Merged

codedup: start using aip-go #434

merged 1 commit into from
Jun 6, 2023

Conversation

glimchb
Copy link
Member

@glimchb glimchb commented Jun 5, 2023

Related to #326

This will help us maintain less code

Signed-off-by: Boris Glimcher [email protected]

Related to opiproject#326

This will help us maintain less code

Signed-off-by: Boris Glimcher <[email protected]>
@glimchb glimchb added the Merge Candidate in the open merge window, next candidate for merge label Jun 5, 2023
@glimchb glimchb marked this pull request as ready for review June 5, 2023 21:27
@glimchb glimchb requested a review from a team as a code owner June 5, 2023 21:27
@glimchb glimchb requested a review from artek-koltun June 5, 2023 21:30
@glimchb
Copy link
Member Author

glimchb commented Jun 5, 2023

see https://github.com/einride/aip-go/blob/a6d86e135bb0e5d1ee09ba2ac2a3806f2fb1e76a/resourceid/systemgenerated.go#L13

// NewSystemGenerated returns a new system-generated resource ID.
func NewSystemGenerated() string {
	return uuid.New().String()
}

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #434 (1028110) into main (f8ecca3) will decrease coverage by 0.07%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #434      +/-   ##
==========================================
- Coverage   79.60%   79.54%   -0.07%     
==========================================
  Files          18       18              
  Lines        2584     2586       +2     
==========================================
  Hits         2057     2057              
- Misses        491      493       +2     
  Partials       36       36              
Impacted Files Coverage Δ
pkg/frontend/scsi.go 0.00% <0.00%> (ø)
pkg/server/utils.go 2.10% <0.00%> (-0.05%) ⬇️
pkg/backend/aio.go 98.52% <100.00%> (ø)
pkg/backend/null.go 98.52% <100.00%> (ø)
pkg/backend/nvme.go 98.02% <100.00%> (ø)
pkg/frontend/blk.go 95.23% <100.00%> (ø)
pkg/frontend/nvme.go 90.27% <100.00%> (ø)
pkg/middleend/encryption.go 100.00% <100.00%> (ø)
pkg/middleend/qos.go 100.00% <100.00%> (ø)

Copy link
Contributor

@artek-koltun artek-koltun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@glimchb glimchb merged commit 765d177 into opiproject:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Candidate in the open merge window, next candidate for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants