Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inline html in md files #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

intelfisz
Copy link
Contributor

No description provided.

Signed-off-by: Filip Szufnarowski <[email protected]>
@intelfisz intelfisz requested a review from a team as a code owner June 30, 2023 13:39
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #123 (8c08b6f) into main (f214b08) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   62.06%   62.06%           
=======================================
  Files           1        1           
  Lines          58       58           
=======================================
  Hits           36       36           
  Misses         15       15           
  Partials        7        7           

Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why?

@intelfisz
Copy link
Contributor Author

intelfisz commented Jul 4, 2023

Can you explain why?

I actually don't understand why this is not enabled by default - html has always been first class citizen in md-files (see e.g. https://stackoverflow.com/questions/40335929/including-html-in-markdown#40342873). If you don't need it, you don't use it but for flexibility and support for basic things like content centering or any kind of documentation styling we should have it enabled.

@intelfisz
Copy link
Contributor Author

@glimchb - any thoughts? this has been open for 2 weeks already.

@glimchb
Copy link
Member

glimchb commented Jul 11, 2023

@glimchb - any thoughts? this has been open for 2 weeks already.

same thoughts. I don't like it

@intelfisz
Copy link
Contributor Author

I don't find it a convincing argument. You don't need to use html if you don't like it and you don't use html in md files by mistake. If you need it though, you should not be blocked to take advantage of it.

@glimchb
Copy link
Member

glimchb commented Jul 11, 2023

I don't find it a convincing argument. You don't need to use html if you don't like it and you don't use html in md files by mistake. If you need it though, you should not be blocked to take advantage of it.

maybe if you can show us what you want to do, we can come up with an alternative without using html ?

@intelfisz
Copy link
Contributor Author

Look above. A basic thing I would like to work is content centering.
Many projects use html just for this simple thing - see e.g. https://github.com/traefik/traefik/blob/master/README.md
or for setting fixed image width like here: https://raw.githubusercontent.com/kubernetes/kubernetes/master/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants