Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrating plugins from otel to bf2 #84

Merged
merged 4 commits into from
Jan 21, 2025
Merged

migrating plugins from otel to bf2 #84

merged 4 commits into from
Jan 21, 2025

Conversation

mohamedasifs123
Copy link
Contributor

Related to #44

@mohamedasifs123
feat: migrating plugins from otel
5ff697a 
Signed-off-by: mohamedasifs123 <[email protected]>
@mohamedasifs123 mohamedasifs123 requested a review from a team as a code owner November 13, 2024 12:50
glimchb
glimchb previously requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@glimchb glimchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test it ? can you attach screens to show new counters ?

@mohamedasifs123
Copy link
Contributor Author

did you test it ? can you attach screens to show new counters ?

Screenshot (23)
@glimchb

@mohamedasifs123
Copy link
Contributor Author

mohamedasifs123 commented Dec 10, 2024 •
edited
Loading 

internal_write,host=bf2,output=file,version=1.31.0 metrics_added=150i,buffer_size=0i,metrics_written=150i,buffer_limit=10000i,startup_errors=0i,errors=0i,write_time_ns=274623i,metrics_dropped=0i,metrics_filtered=0i 1733805700000000000

processes,host=bf2 zombies=0i,running=0i,total=1i,unknown=0i,paging=0i,total_threads=13i,blocked=0i,sleeping=1i,dead=0i,idle=0i,stopped=0i 1733805650000000000

kernel,host=bf2 processes_forked=277367724i,entropy_avail=256i,interrupts=45556082472i,context_switches=62756289006i,boot_time=1723159797i 1733805650000000000

docker,engine_host=bf2,host=bf2,server_version=26.1.3 n_containers=2i,n_images=9i,n_cpus=8i,n_containers_running=2i,n_containers_stopped=0i,n_containers_paused=0i,n_goroutines=58i,n_listener_events=0i,n_used_file_descriptors=38i 1733806670000000000

@sandersms sandersms requested a review from glimchb December 17, 2024 22:13
@mohamedasifs123
fix(ansible): fixing ansible lint
8698e8f 
Signed-off-by: mohamedasifs123 <[email protected]>
sandersms
sandersms approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@sandersms sandersms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable.

@sandersms sandersms dismissed glimchb’s stale review January 21, 2025 20:01

Responses provided by developer with outputs

@sandersms sandersms merged commit 30f339f into opiproject:main Jan 21, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersms sandersms sandersms approved these changes

@glimchb glimchb Awaiting requested review from glimchb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohamedasifs123 @glimchb @sandersms